Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: runtime/BUILD.gn

Issue 1411383004: Enable generation of instruction buffer on precompilation (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address CL concerns Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/gen_snapshot.cc » ('j') | runtime/bin/gen_snapshot.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/BUILD.gn
diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn
index cbc064398d7b5fa50dbc9cb7073622e376fa502e..60805f97dd8e4e629ff4a1fd47e2a8253059132e 100644
--- a/runtime/BUILD.gn
+++ b/runtime/BUILD.gn
@@ -21,6 +21,12 @@ config("dart_public_config") {
config("dart_config") {
defines = []
+ if (target_os == "ios") {
+ # For precompilation, we need to set the target architecture when we
+ # compile the snapshotter on the host. If no instruction buffer is created
rmacnak 2015/10/22 16:46:15 The snapshotter is osx not ios. It would be bette
Chinmay 2015/10/22 19:01:29 ack
+ # on the host, this argument is of no consequence.
+ defines += ["TARGET_ARCH_ARM64"]
+ }
if (dart_debug) {
defines += ["DEBUG"]
} else {
« no previous file with comments | « no previous file | runtime/bin/gen_snapshot.cc » ('j') | runtime/bin/gen_snapshot.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698