[Autofill] Always show available data when encountering autocomplete attributes

components/autofill/core/browser/form_structure_unittest.cc

Index: components/autofill/core/browser/form_structure_unittest.cc
diff --git a/components/autofill/core/browser/form_structure_unittest.cc b/components/autofill/core/browser/form_structure_unittest.cc
index 376ac3bcd590a69939d0d17ce54d69dede2cfd44..b4e49348aac097f2a548160939134848c401b51c 100644
--- a/components/autofill/core/browser/form_structure_unittest.cc
+++ b/components/autofill/core/browser/form_structure_unittest.cc
@@ -305,9 +305,29 @@ TEST_F(FormStructureTest, ShouldBeParsed) {
   EXPECT_TRUE(form_structure->ShouldBeParsed());
 
   form.fields[0].form_control_type = "select-one";
+
   // Now, no text fields.
   form_structure.reset(new FormStructure(form));
   EXPECT_FALSE(form_structure->ShouldBeParsed());
+
+  // The form has two fields but one has the autocomplete attribute

[Mathieu, 2015/10/20 21:03:11]

Please make a separate test case

[sebsg, 2015/10/21 18:20:50]

Done.

+  form.fields.clear();
+
+  field.label = ASCIIToUTF16("Name");
+  field.name = ASCIIToUTF16("name");
+  field.form_control_type = "name";
+  field.autocomplete_attribute = "name";
+  form.fields.push_back(field);
+
+  field.label = ASCIIToUTF16("Address");
+  field.name = ASCIIToUTF16("Address");
+  field.form_control_type = "select-one";
+  field.autocomplete_attribute = "";
+  form.fields.push_back(field);
+
+  form_structure.reset(new FormStructure(form));
+  form_structure->ParseFieldTypesFromAutocompleteAttributes();
+  EXPECT_TRUE(form_structure->ShouldBeParsed());
 }
 
 TEST_F(FormStructureTest, HeuristicsContactInfo) {
@@ -2856,8 +2876,7 @@ TEST_F(FormStructureTest, PossibleValues) {
   form_data.fields.push_back(field);
   FormStructure form_structure(form_data);
 
-  bool unused;
-  form_structure.ParseFieldTypesFromAutocompleteAttributes(&unused, &unused);
+  form_structure.ParseFieldTypesFromAutocompleteAttributes();
 
   // All values in <option> value= or contents are returned, set to upper case.
   std::set<base::string16> possible_values =
@@ -2879,7 +2898,7 @@ TEST_F(FormStructureTest, PossibleValues) {
   freeform_field.autocomplete_attribute = "billing country";
   form_data.fields.push_back(freeform_field);
   FormStructure form_structure2(form_data);
-  form_structure2.ParseFieldTypesFromAutocompleteAttributes(&unused, &unused);
+  form_structure2.ParseFieldTypesFromAutocompleteAttributes();
   EXPECT_EQ(0U, form_structure2.PossibleValues(ADDRESS_BILLING_COUNTRY).size());
 }