Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: components/autofill/content/renderer/form_cache.cc

Issue 1411363003: [Autofill] Always show available data when encountering autocomplete attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/form_cache.cc
diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc
index d513342dae231d6d1a149f0b9c8e187dac6276bc..b616a37b49c7e9eecba1382985b9fea1ebc29907 100644
--- a/components/autofill/content/renderer/form_cache.cc
+++ b/components/autofill/content/renderer/form_cache.cc
@@ -64,8 +64,7 @@ void LogDeprecationMessages(const WebFormControlElement& element) {
// is imposed by WebFormElementToFormData().
bool ShouldIgnoreForm(size_t num_editable_elements,
size_t num_control_elements) {
- return (num_editable_elements < kRequiredAutofillFields &&
- num_control_elements > 0);
+ return (num_editable_elements < 1 && num_control_elements > 0);
Mathieu 2015/10/20 21:03:10 !num_editable_elements && num_control_elements
sebsg 2015/10/21 18:20:50 Done.
}
} // namespace
@@ -117,8 +116,7 @@ std::vector<FormData> FormCache::ExtractNewForms() {
if (num_fields_seen > form_util::kMaxParseableFields)
return forms;
- if (form.fields.size() >= kRequiredAutofillFields &&
- !ContainsKey(parsed_forms_, form)) {
+ if (form.fields.size() >= 1 && !ContainsKey(parsed_forms_, form)) {
Mathieu 2015/10/20 21:03:10 !form.fields.empty() same with change below
sebsg 2015/10/21 18:20:50 Done.
for (auto it = parsed_forms_.begin(); it != parsed_forms_.end(); ++it) {
if (it->SameFormAs(form)) {
parsed_forms_.erase(it);
@@ -155,7 +153,7 @@ std::vector<FormData> FormCache::ExtractNewForms() {
if (num_fields_seen > form_util::kMaxParseableFields)
return forms;
- if (synthetic_form.fields.size() >= kRequiredAutofillFields &&
+ if (synthetic_form.fields.size() >= 1 &&
!parsed_forms_.count(synthetic_form)) {
SaveInitialValues(control_elements);
forms.push_back(synthetic_form);

Powered by Google App Engine
This is Rietveld 408576698