chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 1411363003: [Autofill] Always show available data when encountering autocomplete attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 1411363003: [Autofill] Always show available data when encountering autocomplete attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed bug Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc ('k') | chrome/renderer/autofill/form_autofill_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index ed397097d793279f6bd4a22db6a7dac8c8c86100..baf7ef45d5dfe5da07d31b4d6f83ffe8f4c86e2a 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -422,13 +422,10 @@ void AutofillDialogControllerImpl::Show() {

dialog_shown_timestamp_ = base::Time::Now();

// Determine what field types should be included in the dialog.

- bool has_types = false;

- bool has_sections = false;

- form_structure_.ParseFieldTypesFromAutocompleteAttributes(

- &has_types, &has_sections);

+ form_structure_.ParseFieldTypesFromAutocompleteAttributes();

// Fail if the author didn't specify autocomplete types.

- if (!has_types) {

+ if (!form_structure_.has_author_specified_types()) {

callback_.Run(

AutofillClient::AutocompleteResultErrorDisabled,

base::ASCIIToUTF16("Form is missing autocomplete attributes."),