Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: components/autofill/core/common/autofill_constants.h

Issue 1411363003: [Autofill] Always show available data when encountering autocomplete attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/autofill_constants.h
diff --git a/components/autofill/core/common/autofill_constants.h b/components/autofill/core/common/autofill_constants.h
index 1989e93558d204e76cd9732e24e4454816145dd5..076bb1c852b7f047b27d413fa667a334cee81992 100644
--- a/components/autofill/core/common/autofill_constants.h
+++ b/components/autofill/core/common/autofill_constants.h
@@ -14,11 +14,16 @@ namespace autofill {
// Help URL for the Autofill dialog.
extern const char kHelpURL[];
-// The number of fields required by Autofill. Ideally we could send the forms
-// to Autofill no matter how many fields are in the forms; however, finding the
-// label for each field is a costly operation and we can't spare the cycles if
-// it's not necessary.
-extern const size_t kRequiredAutofillFields;
+// The number of fields required by Autofill to execute its heuristic and
+// crowdsourcing prediction routines. Ideally we would execute those routines no
+// matter how many fields are in the forms; however, finding the label for each
+// field is a costly operation and we can't spare the cycles if it's not
+// necessary.
+extern const size_t kRequiredFieldsForPredictionRoutines;
Evan Stade 2015/11/18 22:59:15 not sure there's a point in making this extern ins
sebsg 2015/11/19 19:25:03 Done.
+
+// The minimum number of fields required to upload a form to the Autofill
+// servers.
+extern const size_t kRequiredFieldsForUpload;
// Options bitmask values for AutofillHostMsg_ShowPasswordSuggestions IPC
enum ShowPasswordSuggestionsOptions {

Powered by Google App Engine
This is Rietveld 408576698