components/autofill/core/browser/autofill_manager.h - Issue 1411363003: [Autofill] Always show available data when encountering autocomplete attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 1411363003: [Autofill] Always show available data when encountering autocomplete attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/form_cache.cc ('K') | « components/autofill/content/renderer/form_cache_unittest.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | components/autofill/core/browser/autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index c7b30297c73cfeb00a31a45a6bb20c575d1c5972..eb6dec6efa54ae731f7f631ecdfa672cefd3b752 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -186,7 +186,7 @@ class AutofillManager : public AutofillDownloadManager::Observer,

// Shared code to determine if |form| should be uploaded to the Autofill

// server. It verifies that uploading is allowed and |form| meets conditions

- // to be uploadable.

+ // to be uploadable. Exposed for testing.

bool ShouldUploadForm(const FormStructure& form);

protected: