Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 1411363003: [Autofill] Always show available data when encountering autocomplete attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index ed397097d793279f6bd4a22db6a7dac8c8c86100..68adde3cf2dc986d7ab1cd55c1d83b00b825d6c1 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -422,13 +422,10 @@ void AutofillDialogControllerImpl::Show() {
dialog_shown_timestamp_ = base::Time::Now();
// Determine what field types should be included in the dialog.
- bool has_types = false;
- bool has_sections = false;
- form_structure_.ParseFieldTypesFromAutocompleteAttributes(
- &has_types, &has_sections);
+ form_structure_.ParseFieldTypesFromAutocompleteAttributes();
// Fail if the author didn't specify autocomplete types.
- if (!has_types) {
+ if (form_structure_.has_author_specified_types()) {
callback_.Run(
AutofillClient::AutocompleteResultErrorDisabled,
base::ASCIIToUTF16("Form is missing autocomplete attributes."),
« no previous file with comments | « no previous file | components/autofill/content/renderer/form_cache.h » ('j') | components/autofill/content/renderer/form_cache.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698