[Autofill] Always show available data when encountering autocomplete attributes

components/autofill/core/browser/form_structure.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 114 matching lines @@
   // to the user's first interaction with the form.  |submission_time| should be
   // a timestamp corresponding to the form's submission.
   void LogQualityMetrics(const base::TimeTicks& load_time,
                          const base::TimeTicks& interaction_time,
                          const base::TimeTicks& submission_time,
                          rappor::RapporService* rappor_service) const;
 
   // Classifies each field in |fields_| based upon its |autocomplete| attribute,
   // if the attribute is available.  The association is stored into the field's
   // |heuristic_type|.
-  // Fills |found_types| with |true| if the attribute is available and neither
-  // empty nor set to the special values "on" or "off" for at least one field.
-  // Fills |found_sections| with |true| if the attribute specifies a section for
+  // Fills |has_author_specified_types_| with |true| if the attribute is
+  // available and neither empty nor set to the special values "on" or "off" for
   // at least one field.
-  void ParseFieldTypesFromAutocompleteAttributes(bool* found_types,
-                                                 bool* found_sections);
+  // Fills |has_author_specified_sections_| with |true| if the attribute
+  // specifies a section for at least one field.
+  void ParseFieldTypesFromAutocompleteAttributes();
 
   // Determines whether |type| and |field| match.
   typedef base::Callback<bool(ServerFieldType type,
                               const AutofillField& field)>
       InputFieldComparator;
 
   // Fills in |fields_| that match |types| (via |matches|) with info from
   // |get_info|. Uses |address_language_code| to determine line separators when
   // collapsing street address lines into a single-line input text field.
   bool FillFields(
@@ skipping 34 matching lines @@
   std::vector<AutofillField*>::const_iterator end() const {
     return fields_.end();
   }
 
   const base::string16& form_name() const { return form_name_; }
 
   const GURL& source_url() const { return source_url_; }
 
   bool has_password_field() const { return has_password_field_; }
 
+  bool has_author_specified_types() { return has_author_specified_types_; }
+
+  bool has_author_specified_sections() {
+    return has_author_specified_sections_;
+  }
+
   void set_upload_required(UploadRequired required) {
     upload_required_ = required;
   }
   UploadRequired upload_required() const { return upload_required_; }
 
   // Returns a FormData containing the data this form structure knows about.
   FormData ToFormData() const;
 
   bool operator==(const FormData& form) const;
   bool operator!=(const FormData& form) const;
@@ skipping 53 matching lines @@
   std::string form_signature_field_names_;
 
   // Whether the server expects us to always upload, never upload, or default
   // to the stored upload rates.
   UploadRequired upload_required_;
 
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;
 
+  // Whether the form includes any sections explicitly specified by the site
+  // author, via the |autocompletetype| attribute.

[Mathieu, 2015/10/20 21:03:11]

nit: "via the autocomplete attribute"

[sebsg, 2015/10/21 18:20:50]

Done.

+  bool has_author_specified_sections_;
+
+  // Whether the form was parsed for autocomplete attribute, thus assigning
+  // the real values of |has_author_specified_types_| and
+  // |has_author_specified_sections_|.
+  bool was_parsed_for_autocomplete_attributes_;
+
   // True if the form contains at least one password field.
   bool has_password_field_;
 
   // True if the form is a <form>.
   bool is_form_tag_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_