Issue 1411323005: Remove a static initializer on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411323005: Remove a static initializer on Windows. (Closed)

Created:
5 years, 1 month ago by Nico

Modified:
5 years, 1 month ago

Reviewers:
tkent

CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove a static initializer on Windows. clang-cl complains: ..\..\third_party\WebKit\Source\core\html\HTMLSelectElement.cpp(80,23) : error: declaration requires a global constructor [-Werror,-Wglobal-constructors] static const unsigned maxListItems = std::numeric_limits<int>::max(); ^ See also thread "[chromium-dev] std::numeric_limits vs INTN_MAX" BUG=82385 TBR=tkent@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/80004a8df9cf8b81f5b231696e3a24d190a8e05b