Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1411313007: mac: Log a message when restarting crashpad_handler (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

mac: Log a message when restarting crashpad_handler This is unexpected and important enough that the restart shouldn’t happen silently. BUG=crashpad:68 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ee58effe14addea2b6a7a14b54b80bd6e5fb37cc

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M client/crashpad_client_mac.cc View 1 5 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-11-08 18:11:00 UTC) #2
Robert Sesek
LGTM
5 years, 1 month ago (2015-11-09 20:56:02 UTC) #3
Mark Mentovai
5 years, 1 month ago (2015-11-09 20:57:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ee58effe14addea2b6a7a14b54b80bd6e5fb37cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698