Issue 1411313005: Backed out validator registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411313005: Backed out validator registration. (Closed)

Created:
5 years, 1 month ago by pquitslund

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Backed out validator registration. Net-net: this bakes in an (unsafe in tests) assumption that the options plugin has been contributed and registered. Backing out pending a revisit. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/15c9636924bf128057a305187c920d9b3cb102ef

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	pkg/analysis_server/lib/src/plugin/server_plugin.dart	View		2 chunks	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

pquitslund

5 years, 1 month ago (2015-10-26 16:46:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
15c9636924bf128057a305187c920d9b3cb102ef (presubmit successful).