printing/printing_context_win.cc - Issue 14113054: printing: Use base::MessageLoop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printing_context_win.cc

Issue 14113054: printing: Use base::MessageLoop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/printing_context_win.cc

diff --git a/printing/printing_context_win.cc b/printing/printing_context_win.cc

index ddfae1aa2b8c371b6b2e9c900f448f94081687e1..967d6a93060a5020e34bf1194611747b702b2bd3 100644

--- a/printing/printing_context_win.cc

+++ b/printing/printing_context_win.cc

@@ -478,8 +478,9 @@ PrintingContext::Result PrintingContextWin::NewDocument(

}

// No message loop running in unit tests.

- DCHECK(!MessageLoop::current() ? true :

- !MessageLoop::current()->NestableTasksAllowed());

+ DCHECK(!base::MessageLoop::current()

Lei Zhang 2013/05/06 04:05:55 How about this? DCHECK(!base::MessageLoop::curren

xhwang 2013/05/06 16:07:20 Done.

+ ? true

+ : !base::MessageLoop::current()->NestableTasksAllowed());

// Begin a print job by calling the StartDoc function.

// NOTE: StartDoc() starts a message loop. That causes a lot of problems with

« printing/printed_document.cc ('K') | « printing/printed_document.cc ('k') | no next file » | no next file with comments »