Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/component_updater/test/component_updater_service_unittest.cc

Issue 14113053: chrome: Use base::MessageLoop. (Part 3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/test/component_updater_service_unittest.cc
diff --git a/chrome/browser/component_updater/test/component_updater_service_unittest.cc b/chrome/browser/component_updater/test/component_updater_service_unittest.cc
index ce85ad1efa8e6f736fb3d8a22ccf46f9e0d8d581..d25e1c97d9fce2ac6a395cfa36069c7e22e88dae 100644
--- a/chrome/browser/component_updater/test/component_updater_service_unittest.cc
+++ b/chrome/browser/component_updater/test/component_updater_service_unittest.cc
@@ -49,7 +49,7 @@ class TestConfigurator : public ComponentUpdateService::Configurator {
// time to break from the test messageloop Run() method so the test can
// finish.
if (--times_ <= 0) {
- MessageLoop::current()->Quit();
+ base::MessageLoop::current()->Quit();
return 0;
}
@@ -272,7 +272,7 @@ TEST_F(ComponentUpdaterTest, VerifyFixture) {
// start-shutdown situation. Failure of this test will be a crash. Also
// if there is no work to do, there are no notifications generated.
TEST_F(ComponentUpdaterTest, StartStop) {
- MessageLoop message_loop;
+ base::MessageLoop message_loop;
content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
component_updater()->Start();
@@ -286,7 +286,7 @@ TEST_F(ComponentUpdaterTest, StartStop) {
// the COMPONENT_UPDATER_STARTED and COMPONENT_UPDATER_SLEEPING notifications
// are generated.
TEST_F(ComponentUpdaterTest, CheckCrxSleep) {
- MessageLoop message_loop;
+ base::MessageLoop message_loop;
content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
content::TestBrowserThread file_thread(BrowserThread::FILE);
content::TestBrowserThread io_thread(BrowserThread::IO);
@@ -365,7 +365,7 @@ TEST_F(ComponentUpdaterTest, CheckCrxSleep) {
// 2- download crx
// 3- second manifest check.
TEST_F(ComponentUpdaterTest, InstallCrx) {
- MessageLoop message_loop;
+ base::MessageLoop message_loop;
content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
content::TestBrowserThread file_thread(BrowserThread::FILE);
content::TestBrowserThread io_thread(BrowserThread::IO);
@@ -430,7 +430,7 @@ TEST_F(ComponentUpdaterTest, InstallCrx) {
// has a different source. In this case there would be two manifest
// checks to different urls, each only containing one component.
TEST_F(ComponentUpdaterTest, InstallCrxTwoSources) {
- MessageLoop message_loop;
+ base::MessageLoop message_loop;
content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
content::TestBrowserThread file_thread(BrowserThread::FILE);
content::TestBrowserThread io_thread(BrowserThread::IO);
@@ -502,7 +502,7 @@ TEST_F(ComponentUpdaterTest, InstallCrxTwoSources) {
// particular there should not be an install because the minimum product
// version is much higher than of chrome.
TEST_F(ComponentUpdaterTest, ProdVersionCheck) {
- MessageLoop message_loop;
+ base::MessageLoop message_loop;
content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
content::TestBrowserThread file_thread(BrowserThread::FILE);
content::TestBrowserThread io_thread(BrowserThread::IO);
@@ -542,7 +542,7 @@ TEST_F(ComponentUpdaterTest, ProdVersionCheck) {
// - We ping.
// - This triggers a second loop, which has a reply that triggers an install.
TEST_F(ComponentUpdaterTest, CheckForUpdateSoon) {
- MessageLoop message_loop;
+ base::MessageLoop message_loop;
content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
content::TestBrowserThread file_thread(BrowserThread::FILE);
content::TestBrowserThread io_thread(BrowserThread::IO);
@@ -658,7 +658,7 @@ TEST_F(ComponentUpdaterTest, CheckForUpdateSoon) {
// Verify that a previously registered component can get re-registered
// with a different version.
TEST_F(ComponentUpdaterTest, CheckReRegistration) {
- MessageLoop message_loop;
+ base::MessageLoop message_loop;
content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
content::TestBrowserThread file_thread(BrowserThread::FILE);
content::TestBrowserThread io_thread(BrowserThread::IO);

Powered by Google App Engine
This is Rietveld 408576698