Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: chrome/browser/extensions/external_policy_loader_unittest.cc

Issue 14113053: chrome: Use base::MessageLoop. (Part 3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <set> 5 #include <set>
6 #include <string> 6 #include <string>
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "base/version.h" 11 #include "base/version.h"
12 #include "chrome/browser/extensions/external_policy_loader.h" 12 #include "chrome/browser/extensions/external_policy_loader.h"
13 #include "chrome/browser/extensions/external_provider_impl.h" 13 #include "chrome/browser/extensions/external_provider_impl.h"
14 #include "chrome/browser/extensions/external_provider_interface.h" 14 #include "chrome/browser/extensions/external_provider_interface.h"
15 #include "chrome/common/extensions/extension.h" 15 #include "chrome/common/extensions/extension.h"
16 #include "chrome/common/extensions/manifest.h" 16 #include "chrome/common/extensions/manifest.h"
17 #include "chrome/common/pref_names.h" 17 #include "chrome/common/pref_names.h"
18 #include "chrome/test/base/testing_pref_service_syncable.h" 18 #include "chrome/test/base/testing_pref_service_syncable.h"
19 #include "chrome/test/base/testing_profile.h" 19 #include "chrome/test/base/testing_profile.h"
20 #include "content/public/test/test_browser_thread.h" 20 #include "content/public/test/test_browser_thread.h"
21 #include "testing/gtest/include/gtest/gtest.h" 21 #include "testing/gtest/include/gtest/gtest.h"
22 22
23 using content::BrowserThread; 23 using content::BrowserThread;
24 24
25 namespace extensions { 25 namespace extensions {
26 26
27 class ExternalPolicyLoaderTest : public testing::Test { 27 class ExternalPolicyLoaderTest : public testing::Test {
28 public: 28 public:
29 ExternalPolicyLoaderTest() 29 ExternalPolicyLoaderTest()
30 : loop_(MessageLoop::TYPE_IO), 30 : loop_(base::MessageLoop::TYPE_IO),
31 ui_thread_(BrowserThread::UI, &loop_) { 31 ui_thread_(BrowserThread::UI, &loop_) {}
brettw 2013/04/28 04:26:27 I much prefer the } on a separate line.
32 }
33 32
34 virtual ~ExternalPolicyLoaderTest() {} 33 virtual ~ExternalPolicyLoaderTest() {}
35 34
36 private: 35 private:
37 // We need these to satisfy BrowserThread::CurrentlyOn(BrowserThread::UI) 36 // We need these to satisfy BrowserThread::CurrentlyOn(BrowserThread::UI)
38 // checks in ExternalProviderImpl. 37 // checks in ExternalProviderImpl.
39 MessageLoop loop_; 38 base::MessageLoop loop_;
40 content::TestBrowserThread ui_thread_; 39 content::TestBrowserThread ui_thread_;
41 }; 40 };
42 41
43 class MockExternalPolicyProviderVisitor 42 class MockExternalPolicyProviderVisitor
44 : public ExternalProviderInterface::VisitorInterface { 43 : public ExternalProviderInterface::VisitorInterface {
45 public: 44 public:
46 MockExternalPolicyProviderVisitor() { 45 MockExternalPolicyProviderVisitor() {
47 } 46 }
48 47
49 // Initialize a provider with |policy_forcelist|, and check that it installs 48 // Initialize a provider with |policy_forcelist|, and check that it installs
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 forced_extensions.SetString("invalid", "http://www.example.com/crx"); 140 forced_extensions.SetString("invalid", "http://www.example.com/crx");
142 forced_extensions.SetString("dddddddddddddddddddddddddddddddd", 141 forced_extensions.SetString("dddddddddddddddddddddddddddddddd",
143 std::string()); 142 std::string());
144 forced_extensions.SetString("invalid", "bad"); 143 forced_extensions.SetString("invalid", "bad");
145 144
146 MockExternalPolicyProviderVisitor mv; 145 MockExternalPolicyProviderVisitor mv;
147 mv.Visit(forced_extensions, expected_extensions); 146 mv.Visit(forced_extensions, expected_extensions);
148 } 147 }
149 148
150 } // namespace extensions 149 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698