LayoutTests/fast/css/first-letter-block-change.html - Issue 14113040: Update the first letter when the first line is changed by adding a new text at its start.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/first-letter-block-change.html

Issue 14113040: Update the first letter when the first line is changed by adding a new text at its start. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@first-letter-rendering-issue

Patch Set: fixed test case failures Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>Test for first-letter that is added by DOM scripting</title>

	5 <style type="text/css">

	6 p:first-letter {text-decoration: underline; color: #CB000F;}

	7 </style>

	8 <script type="text/javascript">

	9 if (window.testRunner)

	10 testRunner.waitUntilDone();

	11

	12 setTimeout(function() {addTextNode()}, 0);
	esprehn 2013/09/27 18:30:15 This doesn't need to use setTimeout, just do: onl This doesn't need to use setTimeout, just do: onload = function() { document.body.offsetTop; addTextNode(); } and then the test doesn't need to be async either.
	13

	14 function addTextNode() {

	15 var textNode = document.createTextNode('I am adding a new text. ');

	16 var para = document.getElementById('test');

	17 para.insertBefore(textNode, para.firstChild);

	18 if (window.testRunner)

	19 testRunner.notifyDone();

	20 }

	21 </script>

	22 </head>

	23 <body>

	24 <p id="test">

	25 This is a test paragraph. You can insert extra text at its start;

	26 the :first-letter styles should be updated to accomodate this new text.

	27 </p>

	28 </body>

	29 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/platform/linux/fast/css/first-letter-block-change-expected.png » ('j') | Source/core/rendering/RenderBlock.cpp » ('J')