Issue 14113034: Check for guest renderer before casting to RenderWidgetHostViewAura in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14113034: Check for guest renderer before casting to RenderWidgetHostViewAura in (Closed)

Created:
7 years, 8 months ago by varunjain

Modified:
7 years, 8 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Check for guest renderer before casting to RenderWidgetHostViewAura in WebContentsViewAura. For guest process, the view is of type RenderWidgetHostViewGuest which can obviously not be casted to RWHVA. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196866

Patch Set 1 #

Patch Set 2 : patch #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	content/browser/web_contents/web_contents_view_aura.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/14113034/2001

7 years, 8 months ago (2013-04-26 19:38:59 UTC) #4

Message was sent while issue was closed.

Change committed as 196866

Expand Messages | Collapse Messages