Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1411303008: GN bootstrap fixes: (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, tfarina
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN bootstrap fixes: - add missing file to compile - fix final build directory (and make --output work) BUG=none R=dpranke@chromium.org,tfarina@chromium.org Committed: https://crrev.com/6a5bdd901706d4c8e8e66478336d5f4ed72aa356 Cr-Commit-Position: refs/heads/master@{#356999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn/bootstrap/bootstrap.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-10-29 13:43:26 UTC) #2
tfarina
lgtm
5 years, 1 month ago (2015-10-29 16:30:24 UTC) #4
Dirk Pranke
lgtm
5 years, 1 month ago (2015-10-29 21:30:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411303008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411303008/1
5 years, 1 month ago (2015-10-30 00:27:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 00:39:27 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 00:40:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a5bdd901706d4c8e8e66478336d5f4ed72aa356
Cr-Commit-Position: refs/heads/master@{#356999}

Powered by Google App Engine
This is Rietveld 408576698