Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1411303002: SkRemote: DrawPaint is an inverse empty path. (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkRemote: DrawPaint is an inverse empty path. Drawing with SkRect::MakeLargest() isn't actually working. This appears to work correctly, and even be correct. (It's a case explicitly handled by SkCanvas::onDrawPath). BUG=skia: Committed: https://skia.googlesource.com/skia/+/1df5fab3856428a014303396615322d8fffcc065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkRemote.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411303002/1
5 years, 2 months ago (2015-10-19 17:31:10 UTC) #2
mtklein_C
5 years, 2 months ago (2015-10-19 17:35:38 UTC) #5
hal.canary
I thought about this solution, but hadn't had time to implement and test. LGTM, assuming ...
5 years, 2 months ago (2015-10-19 17:36:58 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-19 17:40:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411303002/1
5 years, 2 months ago (2015-10-19 17:40:40 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 17:41:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1df5fab3856428a014303396615322d8fffcc065

Powered by Google App Engine
This is Rietveld 408576698