Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 14113021: Added images for disabled print button for PDF plugin. (Closed)

Created:
7 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 8 months ago
Reviewers:
brettw, gene
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Added images for disabled print button for PDF plugin. BUG=224623 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194964

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/renderer/pepper/pepper_pdf_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/c/private/ppb_pdf.h View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/glue/resources/default_100_percent/pdf_button_print_disabled.png View Binary file 0 comments Download
A webkit/glue/resources/default_200_percent/pdf_button_print_disabled.png View Binary file 0 comments Download
M webkit/glue/resources/webkit_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
Added images for disabled print button for PDF plugin. BUG=224623
7 years, 8 months ago (2013-04-16 23:50:06 UTC) #1
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-16 23:52:58 UTC) #2
gene
lgtm
7 years, 8 months ago (2013-04-17 01:49:42 UTC) #3
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-18 17:32:06 UTC) #4
brettw
lgtm
7 years, 8 months ago (2013-04-18 17:36:23 UTC) #5
Vitaly Buka (NO REVIEWS)
Committed patchset #1 manually as r194964.
7 years, 8 months ago (2013-04-18 17:46:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14113021/21003
7 years, 8 months ago (2013-04-18 18:33:30 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 18:33:35 UTC) #8
Presubmit check for 14113021-21003 failed and returned exit status 1.

INFO:root:Found 4 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ppapi/PRESUBMIT.py

** Presubmit Warnings **
Missing PPAPI IDL for private interface, please generate IDL:

***************
  ppapi/c/private/ppb_pdf.h
***************

Presubmit checks took 2.7s to calculate.

Powered by Google App Engine
This is Rietveld 408576698