Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 14113007: Remove the ENABLE_XSLT compile-time flag. (Closed)

Created:
7 years, 8 months ago by Mike West
Modified:
7 years, 8 months ago
Reviewers:
CC:
blink-reviews, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, aandrey+blink_chromium.org, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Remove the ENABLE_XSLT compile-time flag. This mostly mechanical patch shouldn't have any web-visible effect; XSLT has been enabled for quite some time. The only non-mechanical bits of this patch are the drive-by additions of "// namespace WebCore" to the closing braces of a few XSLT files that I noticed while dropping "#endif" statements. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -167 lines) Patch
M Source/WebCore/dom/Document.h View 4 chunks +1 line, -8 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 5 chunks +1 line, -10 lines 0 comments Download
M Source/WebCore/dom/DocumentStyleSheetCollection.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/dom/ProcessingInstruction.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/dom/ProcessingInstruction.cpp View 7 chunks +0 lines, -16 lines 0 comments Download
M Source/WebCore/dom/TransformSource.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/dom/TransformSourceLibxslt.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorPageAgent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResource.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResourceLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResourceLoader.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/loader/cache/CachedXSLStyleSheet.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M Source/WebCore/loader/cache/MemoryCache.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XMLErrors.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/xml/XMLTreeViewer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/xml/XMLTreeViewer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XSLImportRule.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XSLImportRule.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XSLStyleSheet.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XSLStyleSheetLibxslt.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XSLTExtensions.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/xml/XSLTExtensions.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M Source/WebCore/xml/XSLTProcessor.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/xml/XSLTProcessor.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XSLTProcessorLibxslt.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XSLTUnicodeSort.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/xml/XSLTUnicodeSort.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M Source/WebCore/xml/parser/XMLDocumentParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp View 6 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/xml/parser/XMLDocumentParserScope.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/xml/parser/XMLDocumentParserScope.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebCache.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
This is a fairly mechanical patch to drop the XSLT compile-time flag, which we've had ...
7 years, 8 months ago (2013-04-15 10:14:48 UTC) #1
haraken
LGTM
7 years, 8 months ago (2013-04-15 10:22:50 UTC) #2
Mike West
7 years, 8 months ago (2013-04-15 10:27:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r148369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698