Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 14113002: Add UMA stats for GPU feature disable checkbox. (Closed)

Created:
7 years, 8 months ago by Zhenyao Mo
Modified:
7 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, MAD, jar (doing other things), apatrick_chromium, arv+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Add UMA stats for GPU feature disable checkbox. BUG=226874 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193715

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M chrome/browser/gpu/gpu_mode_manager.cc View 1 2 chunks +31 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/actions/chromeactions.txt View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Zhenyao Mo
dbeam: can you review this? apatrick: chrome/browser/gpu/ owner
7 years, 8 months ago (2013-04-10 23:07:07 UTC) #1
apatrick_chromium
chrome/browser/gpu/ LGTM
7 years, 8 months ago (2013-04-10 23:09:16 UTC) #2
Zhenyao Mo
Al, after refactoring, all the code is in chrome/browser/gpu now, so you are THE reviewer. ...
7 years, 8 months ago (2013-04-11 18:06:57 UTC) #3
apatrick_chromium
lgtm
7 years, 8 months ago (2013-04-11 18:15:52 UTC) #4
Zhenyao Mo
On 2013/04/11 18:15:52, apatrick_chromium wrote: > lgtm dbeam: since I didn't hear from you, and ...
7 years, 8 months ago (2013-04-11 19:53:46 UTC) #5
Zhenyao Mo
7 years, 8 months ago (2013-04-11 20:04:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r193715 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698