Start making all .cpp files compile-able on all platforms.

Start making all .cpp files compile-able on all platforms.

I sometimes dream to hone our build process down to something as simple as
    $ find src -name '*.cpp' | xargs c++ <some cflags> -c -o skia.o

To start, it helps if we can compile all files on all platforms.  Each
non-portable file guards itself with defines provided by SkTypes.h.  This does
not convert all non-portable code, but it's a good representative chunk.

E.g. instead of having to remember which SkDebug_*.cpp to compile on which
platform we can just compile all three and let the code itself sort it out.

This has the nice side effect of making non-portable code declare the
conditions under which it can compile explicitly.

I've been testing mostly with the CMake build as it's easiest, but this should
apply equally to BUILD, Gyp, and GN files... to any build system really.

BUG=skia:4269
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/1ee76510f5dbf632d30975fc3509ef4f609156d2

[mtklein, 2015-11-01 22:19:07]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-01 22:19:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411283005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411283005/1

[commit-bot: I haz the power, 2015-11-01 22:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-01 22:30:27]

Dry run: This issue passed the CQ dry run.

[mtklein, 2015-11-01 22:53:41]

Description was changed from

==========
Start making all .cpp files compile-able on all platforms.

I sometimes dream to hone our build process down to something as simple as
    $ find src -name '*.cpp' | xargs c++ <some cflags> -c -o skia.o

To start, it helps if we can compile all files on all platforms.  Each
non-portable file guards itself with defines provided by SkTypes.h.  This does
not convert all non-portable code, but it's a good representative chunk, mostly
Windows-specific.

E.g. instead of having to remember which SkDebug_*.cpp to compile on which
platform we can just compile all three and let the code itself sort it out.

This has the nice side effect of making non-portable code declare the
conditions under which it can compile explicitly.

BUG=skia:4269
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Start making all .cpp files compile-able on all platforms.

I sometimes dream to hone our build process down to something as simple as
    $ find src -name '*.cpp' | xargs c++ <some cflags> -c -o skia.o

To start, it helps if we can compile all files on all platforms.  Each
non-portable file guards itself with defines provided by SkTypes.h.  This does
not convert all non-portable code, but it's a good representative chunk.

E.g. instead of having to remember which SkDebug_*.cpp to compile on which
platform we can just compile all three and let the code itself sort it out.

This has the nice side effect of making non-portable code declare the
conditions under which it can compile explicitly.

BUG=skia:4269
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
==========

[mtklein, 2015-11-01 22:53:45]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-01 22:54:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411283005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411283005/20001

[commit-bot: I haz the power, 2015-11-01 22:54:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-01 22:54:55]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein, 2015-11-01 23:00:41]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-01 23:00:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411283005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411283005/40001

[mtklein, 2015-11-01 23:03:29]

Description was changed from

==========
Start making all .cpp files compile-able on all platforms.

I sometimes dream to hone our build process down to something as simple as
    $ find src -name '*.cpp' | xargs c++ <some cflags> -c -o skia.o

To start, it helps if we can compile all files on all platforms.  Each
non-portable file guards itself with defines provided by SkTypes.h.  This does
not convert all non-portable code, but it's a good representative chunk.

E.g. instead of having to remember which SkDebug_*.cpp to compile on which
platform we can just compile all three and let the code itself sort it out.

This has the nice side effect of making non-portable code declare the
conditions under which it can compile explicitly.

BUG=skia:4269
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Start making all .cpp files compile-able on all platforms.

I sometimes dream to hone our build process down to something as simple as
    $ find src -name '*.cpp' | xargs c++ <some cflags> -c -o skia.o

To start, it helps if we can compile all files on all platforms.  Each
non-portable file guards itself with defines provided by SkTypes.h.  This does
not convert all non-portable code, but it's a good representative chunk.

E.g. instead of having to remember which SkDebug_*.cpp to compile on which
platform we can just compile all three and let the code itself sort it out.

This has the nice side effect of making non-portable code declare the
conditions under which it can compile explicitly.

I've been testing mostly with the CMake build as it's easiest, but this should
apply equally to BUILD, Gyp, and GN files... to any build system really.

BUG=skia:4269
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
==========

[commit-bot: I haz the power, 2015-11-01 23:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-01 23:05:34]

Dry run: Try jobs failed on following builders:
  Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)

[mtklein, 2015-11-01 23:15:31]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-01 23:15:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411283005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411283005/60001

[mtklein, 2015-11-01 23:18:04]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-01 23:18:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411283005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411283005/80001

[commit-bot: I haz the power, 2015-11-01 23:29:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-01 23:29:27]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2015-11-02 17:47:02]

mtklein@chromium.org changed reviewers:
+ reed@google.com
- mtklein@google.com

[mtklein_C, 2015-11-02 17:47:03]

What do you think about something like this?

[reed1, 2015-11-02 17:48:13]

reed@google.com changed reviewers:
+ bsalomon@google.com

[reed1, 2015-11-02 17:48:13]

lgtm

brian, you fine with this pattern?

[bsalomon, 2015-11-02 18:19:01]

On 2015/11/02 17:48:13, reed1 wrote:
> lgtm
> 
> brian, you fine with this pattern?

lgtm

[mtklein, 2015-11-02 18:19:23]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-11-02 18:19:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411283005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411283005/80001

[commit-bot: I haz the power, 2015-11-02 18:20:30]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/1ee76510f5dbf632d30975fc3509ef4f609156d2

[bungeman-skia, 2015-11-24 16:48:14]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2015-11-24 16:48:15]

https://codereview.chromium.org/1411283005/diff/80001/src/ports/SkFontMgr_and...
File src/ports/SkFontMgr_android_factory.cpp (right):

https://codereview.chromium.org/1411283005/diff/80001/src/ports/SkFontMgr_and...
src/ports/SkFontMgr_android_factory.cpp:8: #if defined(SK_BUILD_FOR_ANDROID)
This and the associated header and factory should also be portable. There's
nothing Android specific about this file.