[heap] Fix stale end_ pointer in FreeListCategory::EvictFreeListItemsInList

[heap] Fix stale end_ pointer in FreeListCategory::EvictFreeListItemsInList

During eviction of FreeSpace nodes that reside on eviction pages we iterate
throug the list node-by-node, unlinking only those that reside on eviction
pages. We failed to properly update end_ if nodes were evicted are encountering
nodes that that are left as is.

BUG=chromium:539356
LOG=N
R=hpayer@chromium.org

Committed: https://crrev.com/af4888de13fe2d93601abbb75c43a6d603fb8f78
Cr-Commit-Position: refs/heads/master@{#31383}

[Michael Lippautz, 2015-10-19 13:48:55]

Patchset #1 (id:1) has been deleted

[Michael Lippautz, 2015-10-19 13:49:59]

Description was changed from

==========
[heap] Fix stale end_ pointer in FreeListCategory::EvictFreeListItemsInList

During eviction of FreeSpace nodes that reside on eviction pages we iterate
throug the list node-by-node, unlinking only those that reside on eviction
pages. We failed to properly update end_ if nodes were evicted are encountering
nodes that that are left as is.

BUG=chromium:539356
LOG=N
==========

to

==========
[heap] Fix stale end_ pointer in FreeListCategory::EvictFreeListItemsInList

During eviction of FreeSpace nodes that reside on eviction pages we iterate
throug the list node-by-node, unlinking only those that reside on eviction
pages. We failed to properly update end_ if nodes were evicted are encountering
nodes that that are left as is.

BUG=chromium:539356
LOG=N
R=hpayer@chromium.org
==========

[Michael Lippautz, 2015-10-19 13:58:02]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2015-10-19 13:58:02]

Hannes: PTAL; this is another case where we fail to properly update the end_
pointer if we encounter to-be-evicted nodes after skipping regular nodes.

This could result in ::Concatenate linking up already-allocated nodes:
  category->end()->set_next(top());

Jakob: FYI (it's hard to imagine that this is the bug we are searching for)

[Michael Lippautz, 2015-10-19 13:58:29]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-19 13:58:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411263002/20001

[commit-bot: I haz the power, 2015-10-19 14:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 14:20:03]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2015-10-19 15:01:34]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-19 15:01:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411263002/40001

[commit-bot: I haz the power, 2015-10-19 15:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 15:16:57]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/10844)

[Michael Lippautz, 2015-10-19 15:29:05]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-19 15:29:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411263002/60001

[commit-bot: I haz the power, 2015-10-19 16:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 16:08:06]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2015-10-19 16:14:07]

lgtm

[Michael Lippautz, 2015-10-19 16:29:18]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2015-10-19 16:29:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411263002/60001

[commit-bot: I haz the power, 2015-10-19 16:31:27]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-10-19 16:31:50]

Patchset 3 (id:??) landed as
https://crrev.com/af4888de13fe2d93601abbb75c43a6d603fb8f78
Cr-Commit-Position: refs/heads/master@{#31383}