Issue 1411253013: ABANDONED CL: Adding a save-page test that uses a custom referrer policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411253013: ABANDONED CL: Adding a save-page test that uses a custom referrer policy. (Closed)

Created:
5 years, 1 month ago by Łukasz Anforowicz

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews, asanka

Base URL:
https://chromium.googlesource.com/chromium/src.git@referrer-revert-to-default

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

ABANDONED CL: Adding a save-page test that uses a custom referrer policy. The test forces a rewriting of referrer when fetching 1.png. This test would trigger a crash without a fix in https://codereview.chromium.org/1430003004. BUG=550289, 526786

Patch Set 1 #

Patch Set 2 : Reuploading with no dependencies. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -1 line)			Patch
M	chrome/browser/download/save_page_browsertest.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	chrome/test/data/save_page/b_with_referrer_policy_origin.htm	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	content/browser/download/save_package.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Łukasz Anforowicz

4 years, 9 months ago (2016-03-02 19:28:26 UTC) #1

Description was changed from

==========
Adding a save-page test that uses a custom referrer policy.

The test forces a rewriting of referrer when fetching 1.png.
This test would trigger a crash without a fix in
https://codereview.chromium.org/1430003004.

BUG=550289, 526786
==========

to

==========
ABANDONED CL: Adding a save-page test that uses a custom referrer policy.

The test forces a rewriting of referrer when fetching 1.png.
This test would trigger a crash without a fix in
https://codereview.chromium.org/1430003004.

BUG=550289, 526786
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages