Issue 1411253007: Extract 'computeLineStarts' utility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411253007: Extract 'computeLineStarts' utility. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Extract 'computeLineStarts' utility. R=brianwilkerson@google.com, pquitslund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c095ba1f9191b798bb3c43f4c5994ecb68155948

Patch Set 2 : Move into StringUtilities. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -25 lines)			Patch
M	pkg/analyzer/lib/src/generated/java_engine.dart	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/html.dart	View	1	1 chunk	+1 line, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/options.dart	View	1	2 chunks	+2 lines, -19 lines	0 comments	Download
M	pkg/analyzer/test/generated/utilities_test.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1411253007/diff/1/pkg/analyzer/lib/src/generated/utilities_string.dart File pkg/analyzer/lib/src/generated/utilities_string.dart (right): https://codereview.chromium.org/1411253007/diff/1/pkg/analyzer/lib/src/generated/utilities_string.dart#newcode11 pkg/analyzer/lib/src/generated/utilities_string.dart:11: List<int> computeLineStarts(String content) { Could we add it ...

5 years, 1 month ago (2015-10-27 20:44:10 UTC) #3

scheglov

5 years, 1 month ago (2015-10-27 21:03:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c095ba1f9191b798bb3c43f4c5994ecb68155948 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1411253007: Extract 'computeLineStarts' utility. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Move into StringUtilities. #

Messages