Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1411253004: Remove set_readable call because webrtc will remove this method. (Closed)

Created:
5 years, 2 months ago by honghaiz1
Modified:
5 years, 2 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, pthatcher2
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove set_readable call because webrtc will remove this method. BUG= Committed: https://crrev.com/b0defd00b93f83bf69760555bbb2d89892d930c8 Cr-Commit-Position: refs/heads/master@{#355356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M remoting/protocol/channel_socket_adapter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
honghaiz
5 years, 2 months ago (2015-10-20 18:52:37 UTC) #2
pthatcher2
lgtm
5 years, 2 months ago (2015-10-20 20:05:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411253004/1
5 years, 2 months ago (2015-10-20 20:56:06 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-20 20:56:07 UTC) #10
dcaiafa
lgtm
5 years, 2 months ago (2015-10-21 18:15:14 UTC) #13
Wez
-wez, +sergeyu
5 years, 2 months ago (2015-10-21 18:21:14 UTC) #15
Sergey Ulanov
lgtm
5 years, 2 months ago (2015-10-21 18:29:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411253004/1
5 years, 2 months ago (2015-10-21 18:44:59 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 18:53:21 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 18:54:08 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0defd00b93f83bf69760555bbb2d89892d930c8
Cr-Commit-Position: refs/heads/master@{#355356}

Powered by Google App Engine
This is Rietveld 408576698