Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1411243013: [Android] Fix 'alwaysWatchForChanges' comment in NetworkChangeNotifierAutoDetect. (Closed)

Created:
5 years, 1 month ago by timvolodine
Modified:
5 years, 1 month ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix 'alwaysWatchForChanges' comment in NetworkChangeNotifierAutoDetect. The alwaysWatchForChanges parameter in NetworkChangeNotifierAutoDetect constructor has been replaced by the more generic RegistrationPolicy in crrev.com/1358163004. BUG=520088 Committed: https://crrev.com/92ca9fb193d7f899bb5f3751d966e16f5a7ea1b9 Cr-Commit-Position: refs/heads/master@{#357112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
timvolodine
5 years, 1 month ago (2015-10-30 15:01:44 UTC) #2
xunjieli
LGTM. thanks!
5 years, 1 month ago (2015-10-30 15:04:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411243013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411243013/1
5 years, 1 month ago (2015-10-30 15:05:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 15:58:44 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 15:59:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92ca9fb193d7f899bb5f3751d966e16f5a7ea1b9
Cr-Commit-Position: refs/heads/master@{#357112}

Powered by Google App Engine
This is Rietveld 408576698