Issue 1411243012: Activate windows opened via Service Worker Clients.openWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411243012: Activate windows opened via Service Worker Clients.openWindow (Closed)

Created:
5 years, 1 month ago by johnme

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Activate windows opened via Service Worker Clients.openWindow Fixes https://crbug.com/470830 on Mac, specifically after clicking on a notification, if it opens a window using Clients.openWindow, that window will be properly activated, even if there are no other Chrome windows. BUG=470830

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	content/browser/service_worker/service_worker_version.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

johnme

4 years, 2 months ago (2016-10-17 15:24:51 UTC) #2

Message was sent while issue was closed.

A rebased version of this patch was landed by sdy as
https://codereview.chromium.org/2420733002

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages