Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1411243010: Adding a not explicit source makes it explicit. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adding a not explicit source makes it explicit. When we add a new file in IDEA and open it in the editor, this causes analysis.setSubscriptions to be send immediately, even before watcher notices it. The server reacts by requesting the fully resolved unit, and so causes creation of a not-explicit CacheEntry. So, when later we handle applyChanges(), the entry already exists. In this case we still need to mark it as explicit. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1bc7f930091ed6534d83526c6fd0d75c90e2ebb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-10-30 00:39:51 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-10-30 13:54:24 UTC) #2
scheglov
5 years, 1 month ago (2015-10-30 15:04:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1bc7f930091ed6534d83526c6fd0d75c90e2ebb6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698