Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411243003: Upgrade some tests to use annotations instead of 'clever' confuse() function (Closed)

Created:
5 years, 2 months ago by sra1
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Upgrade some tests to use annotations instead of 'clever' confuse() function. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ef0c55f8a9f7397a52c21e10169cc433b8c856a0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M tests/compiler/dart2js_extra/23404_test.dart View 1 chunk +2 lines, -2 lines 2 comments Download
M tests/compiler/dart2js_extra/useful_error_message_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/generic_instanceof4_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/language/null2_test.dart View 1 chunk +3 lines, -10 lines 0 comments Download
M tests/language/pure_function2_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/language/super_bound_closure_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
https://codereview.chromium.org/1411243003/diff/1/tests/compiler/dart2js_extra/23404_test.dart File tests/compiler/dart2js_extra/23404_test.dart (right): https://codereview.chromium.org/1411243003/diff/1/tests/compiler/dart2js_extra/23404_test.dart#newcode14 tests/compiler/dart2js_extra/23404_test.dart:14: @NoInline() We don't get a warning for this problem ...
5 years, 2 months ago (2015-10-20 17:04:37 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1411243003/diff/1/tests/compiler/dart2js_extra/23404_test.dart File tests/compiler/dart2js_extra/23404_test.dart (right): https://codereview.chromium.org/1411243003/diff/1/tests/compiler/dart2js_extra/23404_test.dart#newcode14 tests/compiler/dart2js_extra/23404_test.dart:14: @NoInline() On 2015/10/20 17:04:37, sra1 wrote: > We ...
5 years, 2 months ago (2015-10-20 19:48:34 UTC) #4
sra1
5 years, 1 month ago (2015-11-02 22:11:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ef0c55f8a9f7397a52c21e10169cc433b8c856a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698