chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc - Issue 1411203010: Separate RenderViewHost from RenderWidgetHost, part 4: delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

Issue 1411203010: Separate RenderViewHost from RenderWidgetHost, part 4: delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: done Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm ('K') | « chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm ('k') | chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc » ('j') | content/browser/renderer_host/render_view_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

diff --git a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

index 68a9ba65d0b8af0221620ab23f8cd2e095c5678e..af6a727def8d75d8443c618327102b08cffa59a9 100644

--- a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

+++ b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

@@ -54,10 +54,10 @@ WebContents* FindFirstDevToolsContents() {

while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {

if (!widget->GetProcess()->HasConnection())

continue;

- if (!widget->IsRenderView())

+ RenderViewHost* view_host = RenderViewHost::From(widget);

+ if (!view_host)

continue;

- RenderViewHost* host = RenderViewHost::From(widget);

- WebContents* contents = WebContents::FromRenderViewHost(host);

+ WebContents* contents = WebContents::FromRenderViewHost(view_host);

GURL url = contents->GetURL();

if (url.SchemeIs(content::kChromeDevToolsScheme))

return contents;