Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: fpdfsdk/src/fsdk_baseform.cpp

Issue 1411203007: Cleanup parts of CPDFSDK_AnnotIterator and CPDFSDK_PageView. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/src/fsdk_annothandler.cpp ('k') | fpdfsdk/src/fsdk_mgr.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/fsdk_baseform.cpp
diff --git a/fpdfsdk/src/fsdk_baseform.cpp b/fpdfsdk/src/fsdk_baseform.cpp
index e083220fe24cb661ea80ddb762b5fce6d7019615..fad28e7b676ea052dca62cee8bde8a4e9d58e3d9 100644
--- a/fpdfsdk/src/fsdk_baseform.cpp
+++ b/fpdfsdk/src/fsdk_baseform.cpp
@@ -2431,7 +2431,7 @@ void CBA_AnnotIterator::GenerateResults() {
switch (m_nTabs) {
case BAI_STRUCTURE: {
- for (int i = 0, sz = m_pPageView->CountAnnots(); i < sz; i++) {
+ for (size_t i = 0; i < m_pPageView->CountAnnots(); ++i) {
CPDFSDK_Annot* pAnnot = m_pPageView->GetAnnot(i);
ASSERT(pAnnot != NULL);
@@ -2443,7 +2443,7 @@ void CBA_AnnotIterator::GenerateResults() {
CPDFSDK_SortAnnots sa;
{
- for (int i = 0, sz = m_pPageView->CountAnnots(); i < sz; i++) {
+ for (size_t i = 0; i < m_pPageView->CountAnnots(); ++i) {
CPDFSDK_Annot* pAnnot = m_pPageView->GetAnnot(i);
ASSERT(pAnnot != NULL);
@@ -2522,7 +2522,7 @@ void CBA_AnnotIterator::GenerateResults() {
CPDFSDK_SortAnnots sa;
{
- for (int i = 0, sz = m_pPageView->CountAnnots(); i < sz; i++) {
+ for (size_t i = 0; i < m_pPageView->CountAnnots(); ++i) {
CPDFSDK_Annot* pAnnot = m_pPageView->GetAnnot(i);
ASSERT(pAnnot != NULL);
« no previous file with comments | « fpdfsdk/src/fsdk_annothandler.cpp ('k') | fpdfsdk/src/fsdk_mgr.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698