Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1411203003: [test] Skip webkit tests with isolates. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Skip webkit tests with isolates. BUG=v8:4499 LOG=n NOTRY=true NOTREECHECKS=true TBR=jkummerow@chromium.org Committed: https://crrev.com/6503b71b55530c1f72301db958871c39b798443f Cr-Commit-Position: refs/heads/master@{#31367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M test/webkit/webkit.status View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
PTAL. Skipping all for now. There are so many failures that skipping * is the ...
5 years, 2 months ago (2015-10-19 11:11:44 UTC) #3
Jakob Kummerow
lgtm
5 years, 2 months ago (2015-10-19 11:19:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411203003/1
5 years, 2 months ago (2015-10-19 11:29:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 11:31:26 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 11:31:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6503b71b55530c1f72301db958871c39b798443f
Cr-Commit-Position: refs/heads/master@{#31367}

Powered by Google App Engine
This is Rietveld 408576698