Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 1411203002: [es6] implement destructuring assignment [clean diff] (Closed)

Created:
5 years, 2 months ago by caitp (gmail)
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] implement destructuring assignment Implement destructuring assignment on top of the parsing implementation (https://crrev.com/1309813007) and the |do expressions| implementation (https://crrev.com/1399893002). BUG=v8:811 LOG=N R=adamk, wingo, aperez, conradw, dehrenberg

Patch Set 1 #

Total comments: 1

Patch Set 2 : Completion-value reusing that may not necessarily accomplish anything #

Total comments: 1

Patch Set 3 : Some fixups for CoverInitializedNames + arrow funcs #

Patch Set 4 : Fix bug in ExpressionClassifier::recorded_first() #

Patch Set 5 : rename `recorded_first()` to `FirstRecorded()` because non-accessor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+589 lines, -46 lines) Patch
M src/bootstrapper.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/expression-classifier.h View 1 2 3 4 8 chunks +47 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +12 lines, -11 lines 0 comments Download
M src/messages.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/parser.h View 1 2 6 chunks +31 lines, -0 lines 0 comments Download
M src/parser.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/preparser.h View 1 2 3 4 31 chunks +223 lines, -29 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 5 chunks +262 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
caitp (gmail)
https://codereview.chromium.org/1411203002/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1411203002/diff/1/src/parser.cc#newcode3613 src/parser.cc:3613: if (value->IsAssignment()) { I'll make all of this completion-value-saving ...
5 years, 2 months ago (2015-10-19 11:17:39 UTC) #1
caitp (gmail)
5 years, 2 months ago (2015-10-19 12:10:50 UTC) #4
https://codereview.chromium.org/1411203002/diff/20001/src/pattern-rewriter.cc
File src/pattern-rewriter.cc (right):

https://codereview.chromium.org/1411203002/diff/20001/src/pattern-rewriter.cc...
src/pattern-rewriter.cc:252: block_->statements()->Add(
I was hoping this would help reduce the number of stack slots used, but it
doesn't seem to make a difference. So maybe worth removing all of that

Powered by Google App Engine
This is Rietveld 408576698