Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 14112003: MIPS: Use PrintF instead of fprintf. (Closed)

Created:
7 years, 8 months ago by palfia
Modified:
7 years, 8 months ago
Reviewers:
kisg, Paul Lind, kilvadyb, danno, Yang
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Use PrintF instead of fprintf. Port r14200 (6ecb8f41), r14204 (08ba63c0) BUG= Committed: https://code.google.com/p/v8/source/detail?r=14218

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/disasm-mips.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
palfia
7 years, 8 months ago (2013-04-11 00:18:27 UTC) #1
Paul Lind
seems fine, but a nit in comments https://codereview.chromium.org/14112003/diff/1/src/mips/disasm-mips.cc File src/mips/disasm-mips.cc (right): https://codereview.chromium.org/14112003/diff/1/src/mips/disasm-mips.cc#newcode1054 src/mips/disasm-mips.cc:1054: v8::internal::PrintF( nit: ...
7 years, 8 months ago (2013-04-11 00:25:37 UTC) #2
palfia
Uploaded a new patchset. https://codereview.chromium.org/14112003/diff/1/src/mips/disasm-mips.cc File src/mips/disasm-mips.cc (right): https://codereview.chromium.org/14112003/diff/1/src/mips/disasm-mips.cc#newcode1054 src/mips/disasm-mips.cc:1054: v8::internal::PrintF( On 2013/04/11 00:25:37, Paul ...
7 years, 8 months ago (2013-04-11 00:39:03 UTC) #3
palfia
On 2013/04/11 00:39:03, palfia wrote: > Uploaded a new patchset. > > https://codereview.chromium.org/14112003/diff/1/src/mips/disasm-mips.cc > File ...
7 years, 8 months ago (2013-04-11 00:44:07 UTC) #4
Paul Lind
LGTM. Yes, I'd missed the 2nd CL of the related ARM change on my first ...
7 years, 8 months ago (2013-04-11 00:45:04 UTC) #5
palfia
7 years, 8 months ago (2013-04-11 00:48:27 UTC) #6
Message was sent while issue was closed.
Committed manually as r14218 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698