Issue 1411193006: Revert of Use SkSwizzler to convert from CMYK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411193006: Revert of Use SkSwizzler to convert from CMYK (Closed)

Created:
5 years, 2 months ago by scroggo

Modified:
5 years, 2 months ago

Reviewers:
msarett, scroggo_chromium

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@NewFromData

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Use SkSwizzler to convert from CMYK (patchset #4 id:60001 of https://codereview.chromium.org/1411083009/ ) Reason for revert: Breaking ASAN. See http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/2879 Original issue's description: > Use SkSwizzler to convert from CMYK > > Move convert_CMYK_to_RGBA into two functions in SkSwizzler: one for 565 > and one for 8888. > > For simplicity, when converting to 8888, we no longer convert in place. > > BUG=skia:4476 > > Committed: https://skia.googlesource.com/skia/+/450ee8f26d39f975cf6af37a27de658ae5a9fa10 TBR=msarett@google.com,scroggo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4476 Committed: https://skia.googlesource.com/skia/+/b7f1251775390cdcf58197fd904d7676b9508128

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -145 lines)			Patch
M	src/codec/SkJpegCodec.cpp	View	7 chunks	+100 lines, -47 lines	0 comments	Download
M	src/codec/SkSwizzler.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/codec/SkSwizzler.cpp	View	2 chunks	+0 lines, -95 lines	0 comments	Download
M	tests/CodexTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411193006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411193006/1

5 years, 2 months ago (2015-10-23 15:39:51 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-23 15:40:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b7f1251775390cdcf58197fd904d7676b9508128

Expand Messages | Collapse Messages