Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1411193002: [debugger] Add test for Debug.scripts without listener. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
noordhuis, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Add test for Debug.scripts without listener. This adds a test case that ensures calling Debug.scripts without any listener attached fails gracefully. For now we are throwing the string "illegal access", this might change in the future to be a dedicated exception. R=yangguo@chromium.org TEST=mjsunit/debug-scripts-throw Committed: https://crrev.com/169627564215dcdedd1c5fb308b73e2a2a512339 Cr-Commit-Position: refs/heads/master@{#31377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
A + test/mjsunit/debug-scripts-throw.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
Yang: PTAL. Ben: FYI.
5 years, 2 months ago (2015-10-19 09:49:55 UTC) #2
Yang
On 2015/10/19 09:49:55, Michael Starzinger wrote: > Yang: PTAL. > Ben: FYI. LGTM.
5 years, 2 months ago (2015-10-19 10:18:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411193002/1
5 years, 2 months ago (2015-10-19 13:32:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 13:34:21 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 13:34:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/169627564215dcdedd1c5fb308b73e2a2a512339
Cr-Commit-Position: refs/heads/master@{#31377}

Powered by Google App Engine
This is Rietveld 408576698