Make MB aware of iOS bot configs and get iOS working.

tools/mb/mb_config.pyl

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   # This is the list of configs that you can pass to mb; each config
   # represents a particular combination of GYP_DEFINES/gn args that
   # we must support. A given config *may* be platform-specific but
   # is not necessarily so (i.e., we might have mac, win, and linux
   # bots all using the 'gn_release_bot' config).
@@ skipping 47 matching lines @@
     'libfuzzer_upload_bot': ['gn', 'release', 'libfuzzer', 'asan'],
 
     # This is just for completeness; any bot that uses this config should never actually run MB.
     'none': ['none'],
 
     'noswarming_gyp_release_bot': ['noswarming', 'gyp', 'release_bot'],
     'noswarming_gyp_release_bot_linux_dump_symbols': ['noswarming', 'gyp', 'release_bot', 'linux_dump_symbols'],
     'noswarming_gyp_release_bot_mac_strip': ['noswarming', 'gyp', 'release_bot', 'mac_strip'],
     'noswarming_gyp_release_bot_x86_linux_dump_symbols': ['noswarming', 'gyp', 'release_bot', 'x86', 'linux_dump_symbols'],
 
+    'passthrough': ['passthrough'],
+
     'swarming_asan_lsan_gyp_release_trybot': ['swarming', 'asan', 'lsan', 'release_trybot'],
     'swarming_msan_gyp_release_trybot': ['swarming', 'chromeos', 'msan', 'gyp', 'release_trybot'],
     'swarming_deterministic_gyp_release_bot': ['swarming', 'deterministic', 'gyp', 'release_bot'],
     'swarming_gpu_tests_gn_release_trybot': ['swarming', 'gpu_tests', 'gn', 'release_trybot'],
     'swarming_gpu_tests_gyp_debug_trybot': ['swarming', 'gpu_tests', 'gyp', 'debug_trybot'],
     'swarming_gpu_tests_gyp_release_trybot': ['swarming', 'gpu_tests', 'gyp', 'release_trybot'],
     'swarming_gn_debug_bot': ['swarming', 'gn', 'debug_bot'],
     'swarming_gn_debug_trybot': ['swarming', 'gn', 'debug_trybot'],
     'swarming_gn_release_bot': ['swarming', 'gn', 'release_bot'],
     'swarming_gn_release_trybot': ['swarming', 'gn', 'release_bot'],
@@ skipping 207 matching lines @@
     'noswarming': {
       'gn_args': '',
       'gyp_defines': 'test_isolation_mode=noop',
     },
 
     'official': {
       'gn_args': 'is_chrome_branded=true is_official_build=true is_debug=false',
       'gyp_defines': 'branding=Chrome buildtype=Official',
     },
 
+    # If this config is used, this means we will use the values for
+    # type, gn_args, gyp_defines, and gyp_crosscompile from the environment
+    # variables MB_TYPE, GN_ARGS, GYP_DEFINES, and GYP_CROSSCOMPILE 
+    # respectively. We do this in order to avoid having to configure bots
+    # in two different src-side places. At the moment this must only be
+    # used on the iOS bots.
+    'passthrough': {
+      'type': 'passthrough',
+    },
+
     'release': {
       'gn_args': 'is_debug=false',
     },
 
     'release_bot': {
       'mixins': ['release', 'static', 'goma'],
     },
 
     'release_bot_minimal_symbols': {
       'mixins': ['release_bot', 'minimal_symbols'],
@@ skipping 83 matching lines @@
       'Android Builder (dbg)': 'android_gyp_debug_static_bot',
       'Android Tests (dbg)': 'android_gyp_debug_static_bot',
       'Android Builder': 'android_gyp_release_bot',
       'Android Tests': 'android_gyp_release_bot',
       'Android Clang Builder (dbg)': 'android_clang_asan_gyp_debug_bot',
       'Android GN': 'android_gn_release_bot',
       'Android GN (dbg)': 'android_gn_debug_bot',
       'Cast Android (dbg)': 'android_cast_gyp_debug_static_bot',
     },
     'chromium.mac': {
+      'iOS Device GN': 'passthrough',
+      'iOS Simulator GN (dbg)': 'passthrough',

[smut, 2015/11/10 22:08:37]

But you still need to enter every GN bot here, in addition to master.cfg,
slaves.cfg, and the bot-specific .json.

Can MB be changed so there's a way to invoke it in --passthrough mode, rather
than having it consult mb_config.pyl and find out it should be in passthrough
mode?

Alternately, can it be set up so any bot that has no entry here defaults to
passthrough mode?

[Dirk Pranke, 2015/11/10 22:46:06]

MB can't do either of those things the code exists in this patch.

One could of course modify the code to do either of these things.

I am reluctant to do so because I'm using mb_config.pyl as the source of truth
for the GYP->GN migration, and if I don't list bots here then it will not be
obvious whether or not they've been even looked at in the context of the
migration.

Of course, adding passthrough at all partially defeats my intentions.

Can we let this go as-is for the moment and revisit this in a subsequent patch
while I think about it some more?

[smut, 2015/11/10 23:30:00]

Agreed that MB can't do these things, but I'm asking for it to be able to.

I hesitate to let this go, because it might end up just staying like this for
awhile, and this makes it even more annoying to add a new bot since it now has
to be enumerated here too. But, iOS upstream bots are added so rarely that I
guess it's ok.

       'Mac GN': 'gn_release_bot',
       'Mac GN (dbg)': 'gn_debug_static_bot',
     },
     'chromium.mojo': {
       'Chromium Mojo Android': 'android_gn_release_bot',
       'Chromium Mojo Linux Perf': 'gn_release_bot',
       'Chromium Mojo Android Nexus5 Perf': 'android_gn_release_bot',
       'Chromium Mojo Windows': 'gn_release_bot_minimal_symbols_x86',
       'Chromium Mojo Linux': 'gn_release_bot',
       'Chromium Mojo Windows 7 Perf': 'gn_release_bot_minimal_symbols_x86',
@@ skipping 84 matching lines @@
       'linux_arm_tester': 'none',
       'linux_chromium_compile_dbg_32_ng': 'swarming_gyp_debug_trybot_x86',
       'linux_chromium_dbg_32_ng': 'swarming_gyp_debug_trybot_x86',
       'linux_chromium_clobber_rel_ng': 'gyp_release_trybot',
       'linux_chromium_gn_upload': 'gn_linux_upload',
       'cast_shell_linux': 'cast_gyp_release_trybot',
       'linux_deterministic': 'swarming_deterministic_gyp_release_bot',
       'linux_ecs_ozone': 'embedded_gyp_debug_bot',
     },
     'tryserver.chromium.mac': {
+      'ios_dbg_simulator_gn': 'passthrough',
+      'ios_rel_device_gn': 'passthrough',
       'mac_chromium_gn_dbg': 'gn_debug_static_bot',
       'mac_chromium_gn_rel': 'gn_release_trybot',
       'mac_chromium_gn_upload': 'gn_release_bot',
     },
     'tryserver.chromium.perf': {
       'android_perf_bisect_builder': 'gyp_official_goma_minimal_symbols_android',
       'android_arm64_perf_bisect_builder': 'gyp_official_goma_minimal_symbols_android_arm64',
       'linux_perf_bisect_builder': 'gyp_official_goma',
       'mac_perf_bisect_builder': 'gyp_official_goma',
       'win_perf_bisect_builder': 'gyp_official_goma_minimal_symbols_x86',
@@ skipping 25 matching lines @@
       'win8_chromium_gn_rel': 'gn_release_trybot_x86',
       'win8_chromium_gn_upload': 'gn_release_bot_minimal_symbols_x86',
       'win_clang_x64_dbg': 'win_clang_debug_bot',
     },
     'tryserver.v8': {
       'v8_linux_chromium_gn_rel': 'gn_release_trybot',
       'v8_android_chromium_gn_dbg': 'android_gn_debug_bot',
     },
   },
 }