Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1411183004: Use JSON instead of YAML for the play services scripts config (Closed)

Created:
5 years, 1 month ago by dgn
Modified:
5 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use JSON instead of YAML for the play services scripts config Bots don't have the yaml python module installed. JSON is supported. Added a parser object that will also hold the description of the different possible fields since JSON doesn't support comments BUG=541727 Committed: https://crrev.com/24f457db32c79f72e5a445bcdf5d6bc0647f4edb Cr-Commit-Position: refs/heads/master@{#357656}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Skip reloading config before save #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -51 lines) Patch
A build/android/play_services/config.json View 1 chunk +3 lines, -0 lines 0 comments Download
D build/android/play_services/config.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
M build/android/play_services/update.py View 5 chunks +9 lines, -8 lines 0 comments Download
M build/android/play_services/utils.py View 1 2 3 chunks +34 lines, -36 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (5 generated)
dgn
PTAL
5 years, 1 month ago (2015-10-28 18:27:21 UTC) #2
dgn
On 2015/10/28 18:27:21, dgn wrote: > PTAL It seems that most bots have the yaml ...
5 years, 1 month ago (2015-11-02 14:06:47 UTC) #3
jbudorick
lgtm w/ nit https://codereview.chromium.org/1411183004/diff/20001/build/android/play_services/utils.py File build/android/play_services/utils.py (right): https://codereview.chromium.org/1411183004/diff/20001/build/android/play_services/utils.py#newcode65 build/android/play_services/utils.py:65: # Reload the configuration in case ...
5 years, 1 month ago (2015-11-03 02:54:41 UTC) #4
dgn
Thanks! https://codereview.chromium.org/1411183004/diff/20001/build/android/play_services/utils.py File build/android/play_services/utils.py (right): https://codereview.chromium.org/1411183004/diff/20001/build/android/play_services/utils.py#newcode65 build/android/play_services/utils.py:65: # Reload the configuration in case the cached ...
5 years, 1 month ago (2015-11-03 10:36:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411183004/40001
5 years, 1 month ago (2015-11-03 10:36:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/135137)
5 years, 1 month ago (2015-11-03 12:55:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411183004/40001
5 years, 1 month ago (2015-11-03 21:30:36 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-03 22:39:28 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 22:41:17 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/24f457db32c79f72e5a445bcdf5d6bc0647f4edb
Cr-Commit-Position: refs/heads/master@{#357656}

Powered by Google App Engine
This is Rietveld 408576698