bluetooth: android: Clean up BluetoothRemoteGattServiceAndroid.

device/bluetooth/bluetooth_remote_gatt_service_android.h

Index: device/bluetooth/bluetooth_remote_gatt_service_android.h
diff --git a/device/bluetooth/bluetooth_remote_gatt_service_android.h b/device/bluetooth/bluetooth_remote_gatt_service_android.h
index a8f1294a5329e4ac2a51fd6d535a940ef5faf73b..2486c9f101f8ce012dbd516772df661ba13ecf39 100644
--- a/device/bluetooth/bluetooth_remote_gatt_service_android.h
+++ b/device/bluetooth/bluetooth_remote_gatt_service_android.h
@@ -28,20 +28,19 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattServiceAndroid
  public:
   // Create a BluetoothRemoteGattServiceAndroid instance and associated Java
   // ChromeBluetoothRemoteGattService using the provided
-  // |bluetooth_remote_gatt_service_wrapper|.
+  // |bluetooth_gatt_service_wrapper|.
   //
   // The ChromeBluetoothRemoteGattService instance will hold a Java reference
-  // to |bluetooth_remote_gatt_service_wrapper|.
-  //
-  // TODO(scheib): Return a scoped_ptr<>, but then device will need to handle
-  // this correctly. http://crbug.com/506416
+  // to |bluetooth_gatt_service_wrapper|.
   static BluetoothRemoteGattServiceAndroid* Create(

[ortuno, 2015/10/26 21:36:26]

This should return a scoped_ptr :p

[scheib, 2015/10/26 21:55:47]

Yes! Ok, now it does.

       BluetoothAdapterAndroid* adapter,
       BluetoothDeviceAndroid* device,
-      jobject bluetooth_remote_gatt_service_wrapper,  // Java Type:
-      // BluetoothRemoteGattServiceWrapper
+      jobject /* BluetoothRemoteGattServiceWrapper */
+      bluetooth_gatt_service_wrapper,
       const std::string& instanceId);
 
+  ~BluetoothRemoteGattServiceAndroid() override;
+
   // Register C++ methods exposed to Java using JNI.
   static bool RegisterJNI(JNIEnv* env);
 
@@ -78,12 +77,9 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattServiceAndroid
       bluetooth_gatt_characteristic_wrapper);
 
  private:
-  friend class BluetoothDeviceAndroid;
-
   BluetoothRemoteGattServiceAndroid(BluetoothAdapterAndroid* adapter,
                                     BluetoothDeviceAndroid* device,
                                     const std::string& instanceId);
-  ~BluetoothRemoteGattServiceAndroid() override;
 
   // Populates |characteristics_| from Java objects if necessary.
   void EnsureCharacteristicsCreated() const;