stop using drawSprite (at least w/ no filters) as it is going away

stop using drawSprite (at least w/ no filters) as it is going away

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4a21602982d411bb764e46dc47e009b12bd5cb39

[reed1, 2015-11-02 18:42:37]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-02 18:42:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411173010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411173010/1

[commit-bot: I haz the power, 2015-11-02 18:56:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 18:56:11]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-11-02 19:35:25]

reed@google.com changed reviewers:
+ robertphillips@google.com, senorblanco@google.com

[robertphillips, 2015-11-02 19:43:15]

lgtm

https://codereview.chromium.org/1411173010/diff/1/samplecode/SampleAll.cpp
File samplecode/SampleAll.cpp (right):

https://codereview.chromium.org/1411173010/diff/1/samplecode/SampleAll.cpp#ne...
samplecode/SampleAll.cpp:442: paint.setShader(nullptr);
rm "sprite" ?

https://codereview.chromium.org/1411173010/diff/1/samplecode/SampleAll.cpp#ne...
samplecode/SampleAll.cpp:572: SkPoint fClickPt;
can we rm fTb ?

[Stephen White, 2015-11-02 19:54:25]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-11-02 19:54:26]

LGTM

[reed1, 2015-11-02 19:55:14]

https://codereview.chromium.org/1411173010/diff/1/samplecode/SampleAll.cpp
File samplecode/SampleAll.cpp (right):

https://codereview.chromium.org/1411173010/diff/1/samplecode/SampleAll.cpp#ne...
samplecode/SampleAll.cpp:442: paint.setShader(nullptr);
On 2015/11/02 19:43:15, robertphillips wrote:
> rm "sprite" ?

Done.

[reed1, 2015-11-02 19:55:18]

The CQ bit was checked by reed@google.com

[reed1, 2015-11-02 19:55:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org, robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1411173010/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-11-02 19:55:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411173010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411173010/20001

[commit-bot: I haz the power, 2015-11-02 20:11:17]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4a21602982d411bb764e46dc47e009b12bd5cb39

[robertphillips, 2015-11-03 12:35:46]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1413363011/ by robertphillips@google.com.

The reason for reverting is: Breaking the bots.

[mtklein, 2015-11-03 13:21:49]

On 2015/11/03 at 12:35:46, robertphillips wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1413363011/ by robertphillips@google.com.
> 
> The reason for reverting is: Breaking the bots.

I think the root of this is tests/RecordReplaceDrawTest.cpp:145, where we assert
that a layer has been hoisted and replaced by a drawSprite() call.  The change
to src/gpu/GrRecordReplaceDraw.cpp means we need to update that to
`assert_type<SkRecords::DrawBitmap>(...)`.  This should be a GPU-only unit test
failure.  The cryptic nature of assert_type failures is probably on me.