Issue 1411173005: Add documentation for allowInterop and allowInteropCaptureThis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411173005: Add documentation for allowInterop and allowInteropCaptureThis (Closed)

Created:
5 years, 1 month ago by Jacob

Modified:
5 years, 1 month ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add documentation for allowInterop and allowInteropCaptureThis BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/sdk/commit/1ea666f401bf384de8f4a27793e0e680f9fbc3ca

Patch Set 4 : ptal... merged with alan's accidental change. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	sdk/lib/js/dartium/js_dartium.dart	View	1 2 3	1 chunk	+19 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

lgtm https://codereview.chromium.org/1411173005/diff/1/sdk/lib/js/dartium/js_dartium.dart File sdk/lib/js/dartium/js_dartium.dart (right): https://codereview.chromium.org/1411173005/diff/1/sdk/lib/js/dartium/js_dartium.dart#newcode1168 sdk/lib/js/dartium/js_dartium.dart:1168: /// using the package:js Dart-JavaScript interop. Add an ...

5 years, 1 month ago (2015-10-27 19:56:18 UTC) #3

Jacob

5 years, 1 month ago (2015-10-27 20:05:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
1ea666f401bf384de8f4a27793e0e680f9fbc3ca (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1411173005: Add documentation for allowInterop and allowInteropCaptureThis (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : ptal... merged with alan's accidental change. #

Messages