Issue 1411173004: GN: mark newlib_pnacl toolchain as clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411173004: GN: mark newlib_pnacl toolchain as clang (Closed)

Created:
5 years, 1 month ago by Petr Hosek

Modified:
5 years, 1 month ago

Reviewers:
Sean Klein

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

GN: mark newlib_pnacl toolchain as clang newlib_pnacl toolchain is based on clang so it should be marked as such to use the correct cflags. BUG= https://github.com/domokit/mojo/issues/396 R=smklein@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0fcbb47f300659ed861ebc8252e47f49b89bb307

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/toolchain/nacl/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Petr Hosek

5 years, 1 month ago (2015-10-26 21:27:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0fcbb47f300659ed861ebc8252e47f49b89bb307 (presubmit successful).