Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1411153007: Begin moving code generation tools from analysis_server to analyzer. (Closed)

Created:
5 years, 2 months ago by Paul Berry
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin moving code generation tools from analysis_server to analyzer. This CL introduces the code generation tools in analyzer, but leaves analysis_server untouched. In a later CL, after a new version of analyzer has been published, I'll refactor analysis_server to point to these tools and remove the corresponding code from analysis_server. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9efcce02c314efd82dcc57a2a6a5a9592cec88d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
A + pkg/analyzer/lib/src/codegen/html.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + pkg/analyzer/lib/src/codegen/text_formatter.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + pkg/analyzer/lib/src/codegen/tools.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
5 years, 2 months ago (2015-10-21 21:57:02 UTC) #3
scheglov
LGTM
5 years, 2 months ago (2015-10-21 22:00:43 UTC) #4
Paul Berry
5 years, 2 months ago (2015-10-22 02:41:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9efcce02c314efd82dcc57a2a6a5a9592cec88d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698