Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: chrome/browser/metrics/variations/BUILD.gn

Issue 1411153006: Variations string overrides now handles more .grd files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments and updated the gyp file (had forgotten to do so ...) Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_resources.gyp » ('j') | chrome/chrome_resources.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations/BUILD.gn
diff --git a/chrome/browser/metrics/variations/BUILD.gn b/chrome/browser/metrics/variations/BUILD.gn
index ed39b8c1fc8a0715b09e5aeab57eb2c174e8a447..3aa5e7c5543ea3d5f7c6acfd062cbd8ea2950a44 100644
--- a/chrome/browser/metrics/variations/BUILD.gn
+++ b/chrome/browser/metrics/variations/BUILD.gn
@@ -8,9 +8,25 @@ import("//components/variations/service/generate_ui_string_overrider.gni")
generate_ui_string_overrider("chrome_ui_string_overrider_factory") {
inputs = [
"$root_gen_dir/chrome/grit/generated_resources.h",
+ "$root_gen_dir/chrome/grit/google_chrome_strings.h",
+ "$root_gen_dir/chrome/grit/chromium_strings.h",
+ "$root_gen_dir/chrome/grit/settings_strings.h",
+ "$root_gen_dir/chrome/grit/settings_chromium_strings.h",
+ "$root_gen_dir/chrome/grit/settings_google_chrome_strings.h",
+ "$root_gen_dir/components/strings/grit/components_strings.h",
+ "$root_gen_dir/components/strings/grit/components_chromium_strings.h",
+ "$root_gen_dir/components/strings/grit/components_google_chrome_strings.h",
]
deps = [
"//chrome/app:generated_resources",
+ "//chrome/app:google_chrome_strings",
+ "//chrome/app:chromium_strings",
+ "//chrome/app:settings_strings",
+ "//chrome/app:settings_chromium_strings",
+ "//chrome/app:settings_google_chrome_strings",
+ "//components/strings:components_strings",
+ "//components/strings:components_chromium_strings",
+ "//components/strings:components_google_chrome_strings",
]
namespace = "chrome_variations"
header_filename = "ui_string_overrider_factory.h"
« no previous file with comments | « no previous file | chrome/chrome_resources.gyp » ('j') | chrome/chrome_resources.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698