Variations string overrides now handles more .grd files

components/variations/service/generate_ui_string_overrider.py

Index: components/variations/service/generate_ui_string_overrider.py
diff --git a/components/variations/service/generate_ui_string_overrider.py b/components/variations/service/generate_ui_string_overrider.py
index 288272cfb5657288af381e752efb2be324298a83..3a152d0cde0b115a93333fc122b2d7972377f98f 100755
--- a/components/variations/service/generate_ui_string_overrider.py
+++ b/components/variations/service/generate_ui_string_overrider.py
@@ -71,6 +71,9 @@ def _GetResourceListFromString(resources_content):
   resources = [Resource(_HashName(name), name, index) for name, index in
                _GetNameIndexPairsIter(resources_content)]
 
+  # Deduplicate resources

[jwd, 2015/10/22 19:00:34]

nit: Add a bit more to the comment, like why you need to do this.

[Moe, 2015/10/26 15:09:26]

Done.

+  resources = list(set(resources))
+
   # The default |Resource| order makes |resources| sorted by the hash, then
   # name, then index.
   resources.sort()
@@ -160,7 +163,7 @@ def _GenerateSourceFileContent(resources_content, namespace, header_filename):
   collisions = _CheckForHashCollisions(hashed_tuples)
   if collisions:
     error_message = "\n".join(
-        ["hash: %i, name: %s" % (i[0], i[1]) for i in sorted(collisions)])
+        ["hash: %i, name: %s" % (i.hash, i.name) for i in sorted(collisions)])
     error_message = ("\nThe following names had hash collisions "
                      "(sorted by the hash value):\n%s\n" %(error_message))
     raise HashCollisionError(error_message)