Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: testing/android/native_test/native_test_launcher.cc

Issue 1411153003: Android GTest Runner: Create flags & test list files only when required (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use null context manager Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/android/native_test/native_test_launcher.cc
diff --git a/testing/android/native_test/native_test_launcher.cc b/testing/android/native_test/native_test_launcher.cc
index ae24e3ffcef9f1bf125726e55d45c91727b9a23f..0f14ff9f52c8364f6d2d962da26ff0ffa86cba1b 100644
--- a/testing/android/native_test/native_test_launcher.cc
+++ b/testing/android/native_test/native_test_launcher.cc
@@ -36,11 +36,6 @@ namespace android {
namespace {
-// The test runner script writes the command line file in
-// "/data/local/tmp".
-static const char kCommandLineFilePath[] =
- "/data/local/tmp/chrome-native-tests-command-line";
-
const char kLogTag[] = "chromium";
const char kCrashedMarker[] = "[ CRASHED ]\n";
@@ -89,7 +84,7 @@ static void RunTests(JNIEnv* env,
const std::string command_line_file_path(
base::android::ConvertJavaStringToUTF8(env, jcommand_line_file_path));
if (command_line_file_path.empty())
- ParseArgsFromCommandLineFile(kCommandLineFilePath, &args);
+ args.push_back("_");
else
ParseArgsFromCommandLineFile(command_line_file_path.c_str(), &args);

Powered by Google App Engine
This is Rietveld 408576698