Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411143002: [test] Pull benchmarks as a dependency. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Pull benchmarks as a dependency. BUG=chromium:535160 LOG=n Committed: https://crrev.com/3e014cb319f91dbe47c7f7b408e114839dd5a2e5 Cr-Commit-Position: refs/heads/master@{#31359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -57 lines) Patch
M .gitignore View 1 chunk +1 line, -5 lines 0 comments Download
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M test/benchmarks/testcfg.py View 3 chunks +19 lines, -52 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Achenbach
PTAL
5 years, 2 months ago (2015-10-19 07:05:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411143002/1
5 years, 2 months ago (2015-10-19 07:31:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-19 07:55:19 UTC) #6
Jakob Kummerow
lgtm
5 years, 2 months ago (2015-10-19 08:24:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411143002/1
5 years, 2 months ago (2015-10-19 08:40:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 08:41:58 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 08:42:26 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3e014cb319f91dbe47c7f7b408e114839dd5a2e5
Cr-Commit-Position: refs/heads/master@{#31359}

Powered by Google App Engine
This is Rietveld 408576698