Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1411133004: Reorder README sections. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
etiennej, qsr
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Reorder README sections. This patch changes the order of README sections from: - checkout > build > sync > run to: - checkout -> sync > build > run R=etiennej@chromium.org, qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/52764c404a222378b3a6edddf2f85b0811c62b86

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M README.md View 2 chunks +16 lines, -15 lines 3 comments Download

Messages

Total messages: 8 (2 generated)
ppi
Hi Etienne or Ben, ptal.
5 years, 1 month ago (2015-11-02 13:57:15 UTC) #3
etiennej
https://codereview.chromium.org/1411133004/diff/1/README.md File README.md (right): https://codereview.chromium.org/1411133004/diff/1/README.md#newcode71 README.md:71: $ git pull --rebase Rebase being optional, do we ...
5 years, 1 month ago (2015-11-02 13:59:39 UTC) #4
ppi
https://codereview.chromium.org/1411133004/diff/1/README.md File README.md (right): https://codereview.chromium.org/1411133004/diff/1/README.md#newcode71 README.md:71: $ git pull --rebase On 2015/11/02 13:59:39, etiennej wrote: ...
5 years, 1 month ago (2015-11-02 14:09:15 UTC) #5
qsr
LGTM (Etienne, I don't think a reformat CL is the right place to change the ...
5 years, 1 month ago (2015-11-02 14:17:03 UTC) #6
etiennej
lgtm https://codereview.chromium.org/1411133004/diff/1/README.md File README.md (right): https://codereview.chromium.org/1411133004/diff/1/README.md#newcode71 README.md:71: $ git pull --rebase On 2015/11/02 14:09:15, ppi ...
5 years, 1 month ago (2015-11-02 14:26:10 UTC) #7
ppi
5 years, 1 month ago (2015-11-02 14:27:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
52764c404a222378b3a6edddf2f85b0811c62b86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698