sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart - Issue 141113011: Support directories other than "web" in pub build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart

Issue 141113011: Support directories other than "web" in pub build. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Revise. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/build/unsupported_build_directories_test.dart ('k') | sdk/lib/_internal/pub/test/build/with_no_web_directory_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart

diff --git a/sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart b/sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart

index c9a19c247ec2fa0acd1b0d1f9d3351220d240df9..963ebf13c7d14b0ef5e007917f7b1cce8983c20b 100644

--- a/sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart

+++ b/sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart

@@ -32,8 +32,7 @@ main() {

var assetsPath = path.join('web', 'assets');

schedulePub(args: ['build'],

- error: getWarningRegExp(assetsPath),

- exitCode: 0);

+ error: getWarningRegExp(assetsPath));

});

integration('warns user about assets dir nested anywhere in "web"', () {

@@ -49,8 +48,7 @@ main() {

var assetsPath = path.join('web', 'foo', 'assets');

schedulePub(args: ['build'],

- error: getWarningRegExp(assetsPath),

- exitCode: 0);

+ error: getWarningRegExp(assetsPath));

});

integration('warns user about assets file in the root of "web"', () {

@@ -64,8 +62,7 @@ main() {

var assetsPath = path.join('web', 'assets');

schedulePub(args: ['build'],

- error: getWarningRegExp(assetsPath),

- exitCode: 0);

+ error: getWarningRegExp(assetsPath));

});

integration('warns user about assets file nested anywhere in "web"', () {

@@ -81,8 +78,7 @@ main() {

var assetsPath = path.join('web', 'foo', 'assets');

schedulePub(args: ['build'],

- error: getWarningRegExp(assetsPath),

- exitCode: 0);

+ error: getWarningRegExp(assetsPath));

});

integration('does not warn if no assets dir or file anywhere in "web"', () {

@@ -96,7 +92,6 @@ main() {

schedulePub(args: ['build'],

error: new RegExp(

- r'^(?!Warning: Pub reserves paths containing "assets").*$'),

- exitCode: 0);

+ r'^(?!Warning: Pub reserves paths containing "assets").*$'));

});

}